More accessible file download link for users who use a screen reader #3264
Conversation
…sers who use a screen reader
tdonohue
added
accessibility
1 APPROVAL
|
@Andrea-Guevara : This PR appears to be failing |
|
Good morning @tdonohue |
IgorBaptist4
force-pushed
the
AccessibilityFileDownloadLinks
branch
from
41c1ccd to
e43469f
Compare
|
Hi @Andrea-Guevara, |
|
Hi @Andrea-Guevara. These changes look good on inspection, but I would like to test them to make sure. Could you fix the merge conflicts? They are in the translation files, so they will be quick. Then I will test the PR right away. |
|
@nwoodward Hello, good afternoon. I've resolved the conflicts. I had some problems with blank spaces in the same translation key files, but these have also been resolved. If you have any questions, I'd be happy to help. |
There was a problem hiding this comment.
Thanks @Andrea-Guevara! I tested these changes, and they add the aria-label attribute to the Download file links.
There was a problem hiding this comment.
👍 Thanks @Andrea-Guevara ! Code looks good to me, and I trust the testing of @nwoodward
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3264-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3264-to-dspace-7_x
git switch --create backport-3264-to-dspace-7_x
git cherry-pick -x c02adead7467f414eefd7849704bf6579f41ef14 405a48378cfa2d598d6cb1ec8ddbec0cf17bb268 e43469f67f0bc91bdd62582cf480c07d07eb4bc4 77ea67c359e238dcd0ef57ca218c94c7a43ecdbd 3c41a4d8e6422e646253dda914cf8620903f76e1 0242fb2d04f733c65a4ca1e58f527f5d9dd00767 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3264-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3264-to-dspace-8_x
git switch --create backport-3264-to-dspace-8_x
git cherry-pick -x c02adead7467f414eefd7849704bf6579f41ef14 405a48378cfa2d598d6cb1ec8ddbec0cf17bb268 e43469f67f0bc91bdd62582cf480c07d07eb4bc4 77ea67c359e238dcd0ef57ca218c94c7a43ecdbd 3c41a4d8e6422e646253dda914cf8620903f76e1 0242fb2d04f733c65a4ca1e58f527f5d9dd00767 |
…Space#3264) * More accessible file download link for users who use a screen reader * Refactoring implementation - More accessible file download link for users who use a screen reader * Fixing import error * Solving the spaces error * Solving the spaces error * Solving the spaces error in file pt-BR.json5 --------- Co-authored-by: andreaNeki <[email protected]>
…Space#3264) * More accessible file download link for users who use a screen reader * Refactoring implementation - More accessible file download link for users who use a screen reader * Fixing import error * Solving the spaces error * Solving the spaces error * Solving the spaces error in file pt-BR.json5 --------- Co-authored-by: andreaNeki <[email protected]>
tdonohue
removed
port to dspace-7_x
…Space#3264) * More accessible file download link for users who use a screen reader * Refactoring implementation - More accessible file download link for users who use a screen reader * Fixing import error * Solving the spaces error * Solving the spaces error * Solving the spaces error in file pt-BR.json5 --------- Co-authored-by: andreaNeki <[email protected]>
References
Description
Adding a more detailed description to the file download link using the “attr.aria-label” attribute.
Instructions for Reviewers
In the anchor of the component “file-download-link.component” the attribute “attr.aria-label” has been added to leave a more detailed description of the functionality of the link for users who make use of a screen reader.
List of changes in this PR:
To reproduce: